ci(acp): add a command-neutral acceptance probe - #3970
Draft
dspury wants to merge 1 commit into
Draft
Conversation
dspury
marked this pull request as ready for review
July 31, 2026 18:15
dspury
force-pushed
the
pr/agent-harness-acceptance-contract
branch
from
August 13, 2026 05:19
55b9401 to
a13b00b
Compare
Validate any caller-supplied ACP executable through initialize and session/new. Preserve repeated argument boundaries, make the handshake timeout configurable, and exercise the contract with a synthetic CI fixture. Signed-off-by: dspury <demitriusspury@gmail.com>
dspury
force-pushed
the
pr/agent-harness-acceptance-contract
branch
from
August 13, 2026 07:30
a13b00b to
276881c
Compare
dspury
marked this pull request as draft
August 13, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a command-neutral acceptance probe for ACP executables. Callers provide the executable and repeatable arguments explicitly; Buzz verifies that the command completes ACP
initializeandsession/newthroughbuzz-acp modelswithin a bounded timeout.The contract depends only on the public ACP process boundary. It does not assume a particular runtime, host, relay, private key, deployment topology, or lifecycle manager.
What changed
scripts/agent-harness-acceptance.shwith required--agent-command, repeatable--agent-arg, and configurable--timeoutoptions.buzz-acp modelswith additive--agent-argand--timeoutoptions while preserving the existing positional argument behavior.scripts/test-agent-harness-acceptance.sh, backed by a synthetic ACP command and fakebuzz-acp, so CI validates success and failure behavior without installing any external runtime.crates/buzz-acp/README.md.The earlier unrelated
ARCHITECTURE.mdprotocol-limit correction and named runtime presets are intentionally not part of this revision.Why
An external ACP implementation should be testable against Buzz without adding runtime-specific discovery, installation, credentials, machine assumptions, or deployment policy to this repository. This probe gives adapter authors a stable executable contract while keeping those concerns with the caller.
Validation
bash -n scripts/agent-harness-acceptance.sh scripts/test-agent-harness-acceptance.shscripts/test-agent-harness-acceptance.shcargo test -p buzz-acpcargo clippy -p buzz-acp --all-targets -- -D warningsbuzz-acp, including arguments containing spaces and commasjust ciThe full
just cigate passed on 2026-08-13, including the current Rust, desktop/Tauri, web, and mobile checks, tests, and builds.Rebuilt as one signed commit on
upstream/mainata96af8952.