Fix PATH on Windows for extensions

[jamadeo]

No description provided.

[Copilot]

Pull request overview

This PR refactors Windows PATH resolution for extensions by replacing custom Windows-specific Node.js installation logic with a centralized SearchPaths-based approach. The changes align with the architecture where the desktop app handles environment setup (including Node.js installation shims on Windows), while the server focuses on command resolution through standard PATH mechanisms.

Key changes:

• Added a resolve_command helper function in extension_manager.rs that uses SearchPaths to resolve executable paths
• Removed ~70 lines of Windows-specific code from agent.rs that checked for and attempted to install Node.js
• Command resolution now falls back gracefully to letting the OS raise errors for missing executables

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/goose/src/agents/extension_manager.rs	Added resolve_command function to resolve commands via SearchPaths; integrated into Stdio extension initialization
crates/goose-server/src/routes/agent.rs	Removed Windows-specific Node.js detection and installation logic from agent_add_extension

[Copilot]

The parameter type &String should be &str for better idiomatic Rust. String slices are more flexible and avoid unnecessary references to heap-allocated strings.

fn resolve_command(cmd: &str) -> PathBuf {

Suggested change

	fn resolve_command(cmd: &String) -> PathBuf {
	fn resolve_command(cmd: &str) -> PathBuf {

[Copilot]

The resolve_command function should use .with_npm() like other providers do (e.g., claude_code, cursor_agent, gemini_cli). This is necessary to properly resolve npm-based commands like npx on Windows, where npm packages may be installed in AppData. Without this, the function won't find npm executables in their standard installation locations.

fn resolve_command(cmd: &String) -> PathBuf {
    SearchPaths::builder().with_npm().resolve(cmd).unwrap_or_else(|_| {
        // let the OS raise the error
        PathBuf::from(cmd)
    })
}

[DOsinga]

hurray

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.