Add error trace#5335
Merged
morgando merged 1 commit intobloomberg:mainfrom Dec 17, 2025
Merged
Conversation
Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>
morgando
commented
Aug 14, 2025
| logmsg(LOGMSG_FATAL, "deadlock in open\n"); | ||
| exit(1); | ||
| } | ||
| print(bdb_state, "open_dbs: cannot open %s: %d %s\n", |
Contributor
Author
There was a problem hiding this comment.
I don't know what print(bdb_state... is used for. If it is still useful then I can add it back.
morgando
commented
Aug 14, 2025
| if (llpagesize) | ||
| pagesize = llpagesize; | ||
| } | ||
| if (!rc && !tmp_bdberr && llpagesize) { pagesize = llpagesize; } |
Contributor
Author
There was a problem hiding this comment.
No logical change here just removing nesting.
roborivers
suggested changes
Aug 14, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 2/625 tests failed ⚠.
The first 10 failing tests are:
sc_transactional_rowlocks_generated
reco-ddlk-sql
mponomar
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out where
open_dbsfailed because there was no trace. The changes in this PR add error logging for two of its error conditions.Hide whitespace changes while looking at diff.