Dead code: del 'newsi' snapshot impl #5596
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
blkseq_serial_generated
analyze
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
|
|
||
| if (!gbl_new_snapisol_asof) { | ||
| DB_LSN lsn = {0}; | ||
| bdb_clean_pglogs_queues(bdb_state, lsn, 0); |
There was a problem hiding this comment.
this function does anything if gbl_new_snapisol is enabled, so deleted that function and all of its invocations.
| PGNO(parent), RE_NREC(parent), &b, | ||
| &parent->lsn)) != 0) | ||
| goto stop; | ||
| if (bdb_relink_pglogs(dbp->dbenv->app_private, |
There was a problem hiding this comment.
There was a problem hiding this comment.
bdb_relink_pglogs doesn't do anything if !gbl_new_snapisol. Deleted it and all invocations.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
| timestamp = txn_dist_commit_args->timestamp; | ||
|
|
||
| ret = | ||
| bdb_transfer_pglogs_to_queues(dbenv->app_private, pglogs, |
There was a problem hiding this comment.
only runs if gbl_new_snapisol. Deleted that function and all of its invocations
| else if (txn_args) | ||
| timestamp = txn_args->timestamp; | ||
|
|
||
| ret = bdb_transfer_pglogs_to_queues(dbenv->app_private, pglogs, keycnt, |
There was a problem hiding this comment.
| goto err; | ||
| } | ||
|
|
||
| ret = bdb_txn_pglogs_init(dbenv->app_private, &txn->pglogs_hashtbl, |
There was a problem hiding this comment.
only does anything if gbl_new_snapisol. deleted function and invocations.
|
|
||
| /* We use the (incorrect) 'prepare' lsn collecting pglogs above */ | ||
| bdb_update_pglogs_commitlsn(dbenv->app_private, p->pglogs, p->keycnt, lsn_out); | ||
| bdb_transfer_pglogs_to_queues(dbenv->app_private, p->pglogs, p->keycnt, 0, |
There was a problem hiding this comment.
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
insert_lots
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
insert_lots_ssl_generated
Signed-off-by: mdouglas47 <[email protected]>
Signed-off-by: mdouglas47 <[email protected]>
riverszhang89
force-pushed
the
del_newsi
branch
from
71886d0 to
f0551e7
Compare
|
Thanks Rivers! |
3 participants
Cleaned up the 'newsi' snapshot implementation. This was a conservative pass — I only removed code that was clearly gated behind newsi tunables. There’s probably some leftover newsi logic that isn’t behind a tunable and could be cleaned up later, but this should cover most of it.