Skip to content

Conversation

@chands10
Copy link
Contributor

@chands10 chands10 commented Dec 3, 2025

per monday discussion

if (hndl->ack)
ack(hndl);

if (hndl->auto_consume_timeout_ms > 0 && hndl->sb && !hndl->in_trans && hndl->firstresponse &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this was disabled by default anyways since consume timeout ms = 0

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logdelete_snapshot_generated [setup failure]
load_cache_dumpmax_generated [setup failure]
load_cache_autocache_generated [setup failure]
instant_sc_logicalsc_generated [setup failure]
diskspace_nollmeta_nostripe_generated [setup failure]
dbreg_race_ufid_on_generated [setup failure]
insert_lots_ssl_generated
keycompr
jsonify
instant_sc

@chands10 chands10 force-pushed the remove_drain branch 3 times, most recently from cb181f5 to af02954 Compare December 9, 2025 16:46
@chands10 chands10 changed the title Remove auto consume rows Remove auto consume timeout Dec 9, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots
truncatesc
analyze
consumer_non_atomic_default_consumer_generated
cdb2_close
insert_lots_ssl_generated
reco-ddlk-sql
incoh_remsql_rte_connect_generated
incoh_remsql

Signed-off-by: Salil Chandra <[email protected]>
@chands10
Copy link
Contributor Author

chands10 commented Dec 9, 2025

/adhoc-test cdb2_close

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants