-
Notifications
You must be signed in to change notification settings - Fork 231
Remove auto consume timeout #5605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| if (hndl->ack) | ||
| ack(hndl); | ||
|
|
||
| if (hndl->auto_consume_timeout_ms > 0 && hndl->sb && !hndl->in_trans && hndl->firstresponse && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this was disabled by default anyways since consume timeout ms = 0
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logdelete_snapshot_generated [setup failure]
load_cache_dumpmax_generated [setup failure]
load_cache_autocache_generated [setup failure]
instant_sc_logicalsc_generated [setup failure]
diskspace_nollmeta_nostripe_generated [setup failure]
dbreg_race_ufid_on_generated [setup failure]
insert_lots_ssl_generated
keycompr
jsonify
instant_sc
cb181f5 to
af02954
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
insert_lots
truncatesc
analyze
consumer_non_atomic_default_consumer_generated
cdb2_close
insert_lots_ssl_generated
reco-ddlk-sql
incoh_remsql_rte_connect_generated
incoh_remsql
af02954 to
cffd032
Compare
Signed-off-by: Salil Chandra <[email protected]>
cffd032 to
51b8ff5
Compare
|
/adhoc-test cdb2_close |
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
per monday discussion