Conversation
|
Thanks for adding this John! One thing we will have to watch for is timeout since these coverage runs can be lengthy. I had to break the Codecov up by test-suite to avoid that. If that does happen we can always ping Sam and ask him if there's a way to do the same thing (or if he can implement it) with this coverage generator. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
===========================================
- Coverage 95.34% 95.34% -0.01%
===========================================
Files 825 825
Lines 68160 68160
===========================================
- Hits 64987 64986 -1
- Misses 3173 3174 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Not so fast, nothing was run! Any ideas @mborland ? |
It was set to only run on push to develop or master. Now I have it set to the same conditions that run our Codecov runs. I wasn't sure if that was a limitation of the new coverage machinery or not. |
|
It does look like we are limited to pushes to develop and master for right now. I will remove my commit |
ea9c1e9 to
20e9efd
Compare
|
Oh :( |
No description provided.