Fix constexpr round implementation for values in the range -1.0 to -0.5 and 0.5 to 1.0#1370
Merged
mborland merged 1 commit intoboostorg:developfrom Feb 24, 2026
Merged
Conversation
…e 0.5-1.0 to round to zero
mborland
approved these changes
Feb 24, 2026
Member
mborland
left a comment
mborland
left a comment
There was a problem hiding this comment.
LGTM. Thank you! I kicked off the CI and will merge once it's green.
Member
|
CI failure unrelated. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the constexpr implementations of the ccmath round functions, values between +-0.5 and +-1.0 are incorrectly rounded to zero. The fix is just to use the correct comparison operators in
round_impl. I've also added some compile-time tests for the affected values