Conversation
|
This one I based on #190 just to avoid textual conflicts and having to redo the tests in that PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements by refactoring integration tests to consistently use xshell for command execution, enhancing readability and maintainability. It also adds a new kernel module for robust kernel and Unified Kernel Image (UKI) detection, which is crucial for supporting diverse bootc images. The integration of this module into run_ephemeral and the addition of new UKI-specific integration tests demonstrate a strong commitment to compatibility and reliability. Furthermore, the docs/todo/ephemeral-uefi.md document provides excellent foresight and planning for future UEFI boot support. Overall, these changes represent a substantial positive step for the project.
cgwalters
force-pushed
the
xshell-tests
branch
from
5006e33 to
d6b54f9
Compare
Replace verbose std::process::Command usage with xshell's cmd! macro
throughout the integration tests. This provides cleaner syntax with
safe variable interpolation and reduces boilerplate significantly.
Key patterns used:
- cmd!(sh, "...").read()? for capturing stdout
- cmd!(sh, "...").ignore_status().output()? for fallible commands
- {var} interpolation and {args...} array expansion
The run_bcvk() helper and VmCleanupGuard Drop impl intentionally
retain std::process::Command for consistent CapturedOutput handling
and because Shell::new() is fallible in Drop contexts.
Assisted-by: Claude Code (Sonnet 4)
Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
xshell-tests
branch
from
d6b54f9 to
55bd9c3
Compare
2 participants
No description provided.