Publish development binaries as OCI artifacts#198
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new section in the installation.md documentation, providing instructions for users to download and install development binaries of bcvk as OCI artifacts. This is a valuable addition, as it simplifies the process of testing unreleased features without requiring users to build from source. The instructions are generally clear and well-structured. I have provided one suggestion to enhance the clarity regarding the target architecture for the provided oras pull command.
gursewak1997
force-pushed
the
publish-binaries-oci
branch
from
e0d683c to
a114d1c
Compare
gursewak1997
force-pushed
the
publish-binaries-oci
branch
from
a114d1c to
749c67f
Compare
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Looks sane to me but we can improve pre or post merge as you prefer!
.github/workflows/main.yml
Outdated
| steps: | ||
| - name: Install ORAS CLI | ||
| run: | | ||
| curl -LO https://github.com/oras-project/oras/releases/download/v1.2.2/oras_1.2.2_linux_amd64.tar.gz |
There was a problem hiding this comment.
Should renovate bump this probably.
BTW another option we could add it to our devcontainer - ref bootc-dev/infra#55
There was a problem hiding this comment.
Using renovate for now. We can start using dev/container in a follow up PR
gursewak1997
force-pushed
the
publish-binaries-oci
branch
from
749c67f to
657abc6
Compare
renovate.json
Outdated
| { | ||
| "fileMatch": ["^\\.github/workflows/.*\\.yml$"], | ||
| "matchStrings": [ | ||
| "https://github\\.com/oras-project/oras/releases/download/v(?<currentValue>.*?)/oras_.*?\\.tar\\.gz" |
There was a problem hiding this comment.
I think it's more elegant to use our "magic comment" renovate matcher ref e.g. https://github.com/bootc-dev/infra/blob/18de41177681a7cca0e2af587db46c981dc4a729/devenv/Containerfile.debian#L29
That should Just Work with our shared config I think https://github.com/bootc-dev/infra/blob/18de41177681a7cca0e2af587db46c981dc4a729/renovate-shared-config.json
There was a problem hiding this comment.
Should be good to go now
Adds GitHub workflow to publish bcvk binaries from main branch to ghcr.io/bootc-dev/bcvk-binary as OCI artifacts. This enables testing unreleased features in downstream CI (like bootc) without building from the source. Binaries can be pulled with: oras pull ghcr.io/bootc-dev/bcvk-binary:x86_64-latest Fixes:#181 Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
publish-binaries-oci
branch
from
657abc6 to
be550f1
Compare
2 participants
Adds GitHub workflow to publish bcvk binaries from main branch to ghcr.io/bootc-dev/bcvk-binary as OCI artifacts. This enables testing unreleased features in downstream CI (like bootc) without building from the source.
Binaries can be pulled with: oras pull ghcr.io/bootc-dev/bcvk-binary:x86_64-latest
Fixes: #181
Assisted-by: Claude Code (Sonnet 4.5)