Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a --readonly flag to the usroverlay command, allowing the creation of a read-only transient overlay on /usr. The changes are well-implemented across the CLI, the two backends (ostree and composefs), documentation, and tests. The code is clear and the new functionality is tested. I have one minor suggestion to improve code conciseness.
Comment on lines
+1417
to
+1422
| let args = match access_mode { | ||
| // In this context, "--transient" means "read-only overlay" | ||
| FilesystemOverlayAccessMode::ReadOnly => ["admin", "unlock", "--transient"].as_slice(), | ||
|
|
||
| FilesystemOverlayAccessMode::ReadWrite => ["admin", "unlock"].as_slice(), | ||
| }; |
Contributor
There was a problem hiding this comment.
This match statement can be simplified into an if/else expression to make it more concise.
Suggested change
| let args = match access_mode { | |
| // In this context, "--transient" means "read-only overlay" | |
| FilesystemOverlayAccessMode::ReadOnly => ["admin", "unlock", "--transient"].as_slice(), | |
| FilesystemOverlayAccessMode::ReadWrite => ["admin", "unlock"].as_slice(), | |
| }; | |
| let args: &[&str] = if access_mode == FilesystemOverlayAccessMode::ReadOnly { | |
| // In this context, "--transient" means "read-only overlay" | |
| &["admin", "unlock", "--transient"] | |
| } else { | |
| &["admin", "unlock"] | |
| }; |
Signed-off-by: Evan Goode <mail@evangoo.de>
Signed-off-by: Evan Goode <mail@evangoo.de>
Signed-off-by: Evan Goode <mail@evangoo.de>
Signed-off-by: Evan Goode <mail@evangoo.de>
311143c to
331b8b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2034.