Skip to content

Add Trustabl security scanning to CI - #634

Closed
Joshua - Trustabl (joshua-trustabl) wants to merge 1 commit into
braintrustdata:mainfrom
joshua-trustabl:add-trustabl-action
Closed

Add Trustabl security scanning to CI#634
Joshua - Trustabl (joshua-trustabl) wants to merge 1 commit into
braintrustdata:mainfrom
joshua-trustabl:add-trustabl-action

Conversation

@joshua-trustabl

Copy link
Copy Markdown

We came across your repo and we like how you're building an accessible framework for Python developers to interact with Braintrust's AI evaluation features. We scanned the repo, and noticed agent runtime reliability findings that might be worth reviewing.

  1. [HIGH] Session permission mode bypasses approvals
    What it means: A ClaudeAgentOptions(.py file) is configured for session_permission_mode=True without any explicit approval mechanism or safeguard. This could lead to unauthorized access to sensitive information or actions if an attacker gains control of the agent. 2. [HIGH] Agent uses web search built-in without before_tool_callback
    File: integrations/adk-py/examples/parallel/agent.py
    What it means: This LlmAgent is wired with a web search built-in (the google_search instance, GoogleSearchTool, or VertexAiSearchTool) but has no before_tool_callback. This lack of oversight could allow malicious websites to be accessed or injected into the agent's responses, compromising security and data integrity.

  2. [HIGH] Agent uses web search built-in without before_tool_callback
    File: integrations/adk-py/examples/parallel/agent.py
    What it means: This LlmAgent is wired with a web search built-in (the google_search instance, GoogleSearchTool, or VertexAiSearchTool) but has no before_tool_callback. This lack of oversight could allow malicious websites to be accessed or injected into the agent's responses, compromising security and data integrity.

Recommendations are based on our understanding of agent runtime reliability, some findings may be intentional. Please let us know if this was intentional or if our findings are helpful so we can improve the accuracy of the scanner.

Best,
Trustabl.ai
Open-source AI agent reliability scanner (runs locally, GitHub Action)

@AbhiPrasad

Copy link
Copy Markdown
Member

Hey, we already have other security scanning tools. We aren't interested in this one. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants