Add Trustabl security scanning to CI - #634
Closed
Joshua - Trustabl (joshua-trustabl) wants to merge 1 commit into
Closed
Add Trustabl security scanning to CI#634Joshua - Trustabl (joshua-trustabl) wants to merge 1 commit into
Joshua - Trustabl (joshua-trustabl) wants to merge 1 commit into
Conversation
Member
|
Hey, we already have other security scanning tools. We aren't interested in this one. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We came across your repo and we like how you're building an accessible framework for Python developers to interact with Braintrust's AI evaluation features. We scanned the repo, and noticed agent runtime reliability findings that might be worth reviewing.
[HIGH] Session permission mode bypasses approvals
What it means: A ClaudeAgentOptions(.py file) is configured for session_permission_mode=True without any explicit approval mechanism or safeguard. This could lead to unauthorized access to sensitive information or actions if an attacker gains control of the agent. 2. [HIGH] Agent uses web search built-in without before_tool_callback
File: integrations/adk-py/examples/parallel/agent.py
What it means: This LlmAgent is wired with a web search built-in (the google_search instance, GoogleSearchTool, or VertexAiSearchTool) but has no before_tool_callback. This lack of oversight could allow malicious websites to be accessed or injected into the agent's responses, compromising security and data integrity.
[HIGH] Agent uses web search built-in without before_tool_callback
File: integrations/adk-py/examples/parallel/agent.py
What it means: This LlmAgent is wired with a web search built-in (the google_search instance, GoogleSearchTool, or VertexAiSearchTool) but has no before_tool_callback. This lack of oversight could allow malicious websites to be accessed or injected into the agent's responses, compromising security and data integrity.
Recommendations are based on our understanding of agent runtime reliability, some findings may be intentional. Please let us know if this was intentional or if our findings are helpful so we can improve the accuracy of the scanner.
Best,
Trustabl.ai
Open-source AI agent reliability scanner (runs locally, GitHub Action)