Open
Conversation
- Add Docker Buildx setup to workflow - Use GHA cache for docker builds to speed up CI - Cache is shared across all layers and PHP versions for maximum reuse - Conditional cache flags only apply in GitHub Actions, works locally without cache
The notdir function strips the 'layers/' prefix from the directory path, ensuring the image is tagged as 'bref/sqlsrv-php-82' instead of 'bref/layers/sqlsrv-php-82', which matches what the test Dockerfile expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use gha cache, fixed version after #628
Root Cause
The original PR changed from docker build to docker buildx build --load, but this exposed an existing bug in the Makefile's image naming. When building layers like layers/sqlsrv, the image was tagged as
bref/layers/sqlsrv-php-82 instead of bref/sqlsrv-php-82, causing the test step to fail with:
ERROR: pull access denied, repository does not exist or may require authorization:
server message: insufficient_scope: authorization failed
Fix Applied
Updated the Makefile to strip the layers/ directory prefix from image names:
This ensures images are correctly tagged as bref/sqlsrv-php-82 (without the layers/ prefix), matching what the test Dockerfile expects.
Testing
The fix ensures that: