Add -fb/--fakebattery flag; -fh alone no longer fakes the BQ25895#535
Open
brickbots wants to merge 1 commit into
Open
Add -fb/--fakebattery flag; -fh alone no longer fakes the BQ25895#535brickbots wants to merge 1 commit into
brickbots wants to merge 1 commit into
Conversation
-fh/--fakehardware used to force has_bq25895 (and has_buzzer) so the fake battery monitor always ran, putting the rev-4 battery indicator in every headless capture. Docs screenshots should show the baseline rev-3 UI (128x128, no battery icon), so -fh now leaves has_bq25895 off and a new -fb/--fakebattery flag opts back into the fake battery monitor for rev-4 work. has_buzzer stays set under -fh; the sound process is already gated on real hardware. Documented both flags in the dev guide. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-fh/--fakehardwareused to forcehas_bq25895(andhas_buzzer) so the fake battery monitor always ran — which put the rev-4 battery indicator in the title bar of every headless capture. Docs screenshots should show the baseline rev-3 UI (128x128, no battery indicator), so:-fhalone now emulates rev-3 hardware:has_bq25895stays off, no battery monitor, no battery icon.-fb/--fakebatteryflag opts back into the rev-4 fake battery monitor (battery_fakeis only imported when the flag is given, matching the real-hardware branch's probe-then-import pattern).has_buzzerremains set under-fh; the sound process is already gated on real hardware so this changes nothing in dev.Testing
ruff check/ruff formatclean; smoke tests pass./api/screen:-fhonly: startup log shows no Battery process; title bar has no battery icon.-fh -fb: Battery process spawns (Write: Battery); battery icon renders in the title bar.🤖 Generated with Claude Code