Skip to content

feat: reviewpayload priority rules (axe-core)#245

Open
rajathmr2000 wants to merge 8 commits into
mainfrom
feat/AXE-3625-bulk-review-priority
Open

feat: reviewpayload priority rules (axe-core)#245
rajathmr2000 wants to merge 8 commits into
mainfrom
feat/AXE-3625-bulk-review-priority

Conversation

@rajathmr2000

@rajathmr2000 rajathmr2000 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Wire metadata.defaultCategory for the prioritized rules (aria-valid-attr-value,
video-caption, bypass, css-orientation-lock) and emit reviewPayload.visualHelperData
for aria-valid-attr-value. Excludes aria-hidden-focus / identical-links-same-purpose
/ duplicate-id-aria (deferred).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rajathmr2000 rajathmr2000 changed the title AXE-3625: Bulk-review priority rules (axe-core subset) feat: Bulk-review priority rules (axe-core subset) Jun 29, 2026
Update the 8 needs-review deepEqual expectations in valid-attr-value.js
to include the reviewPayload the check now emits on the needs-review
path, and add the // a11y-rule-aria-valid-attr-value tag on the emit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@mattscepter mattscepter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 inline finding(s). Full report in the PR comment below. Verdict: Failed - see PR comment.

mattscepter
mattscepter previously approved these changes Jun 29, 2026
Comment thread lib/checks/aria/aria-valid-attr-value-evaluate.js Outdated
rajathmr2000 and others added 4 commits June 29, 2026 14:32
Normalize the // a11y-rule comment indentation (tab -> spaces) so
fmt:check (prettier --check) passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rajathmr2000 added a commit that referenced this pull request Jun 29, 2026
Make this branch's tree identical to feat/AXE-3625-bulk-review-priority (#245) so #244 carries the agreed priority-rule scope.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rajathmr2000 rajathmr2000 changed the title feat: Bulk-review priority rules (axe-core subset) feat: reviewpayload priority rules (axe-core) Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants