feat!: Removes warg (rebased on main)#193
Conversation
|
Given that we're doing this in large part to ease #99 I wonder if we can just use this branch as the source for that migration, combining this smaller breaking change into that larger breaking change. |
|
We certainly still want to do this, but given that there are some conflicts, @karthik2804 would you mind reworking this to resolve the conflicts? We're happy to remake the PR as well of course but if you have the cycles would be happy to wait a bit and merge this PR. |
|
I can take a stab at that. |
This PR only focuses on removing warg with some basic updates to the documentation. Ideally we can change the config file as well, but I figured it would be good to start Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
karthik2804
force-pushed
the
feat/remove_warg
branch
from
97ad726 to
6ab1da1
Compare
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for taking the time to rework this PR @karthik2804 ! I'll hold off on merging right now just in case you have any last things to change, but otherwise let's get this merged!
|
@vados-cosmonic I think it can be merged. |
4 participants
This PR is the rebased version of #152 to make it easier to review and move it forward.