Skip to content

Consolidate wasm features in config.rs#13605

Open
alexcrichton wants to merge 1 commit into
bytecodealliance:mainfrom
alexcrichton:wasmtime-wasm3
Open

Consolidate wasm features in config.rs#13605
alexcrichton wants to merge 1 commit into
bytecodealliance:mainfrom
alexcrichton:wasmtime-wasm3

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Use the WASM3 fixed feature set which Wasmtime now implements by default.

Use the `WASM3` fixed feature set which Wasmtime now implements by
default.
@alexcrichton alexcrichton requested a review from a team as a code owner June 10, 2026 02:49
@alexcrichton alexcrichton requested review from dicej and removed request for a team June 10, 2026 02:49
@alexcrichton alexcrichton added this pull request to the merge queue Jun 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 10, 2026
@github-actions github-actions Bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Jun 10, 2026
@github-actions

Copy link
Copy Markdown

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@@ -2423,20 +2423,20 @@ impl Config {
fn features(&self) -> WasmFeatures {
// Wasmtime by default supports all of the wasm 2.0 version of the

@dicej dicej Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still accurate and relevant given the change from WasmFeatures::WASM2 to WasmFeatures::empty()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants