fix(tests): loosen p3 outbound content length error conditions#13606
Merged
Conversation
Contributor
Author
|
Special shout out to @rvolosatovs -- please let me know if I missed anything here intent-wise. |
rvolosatovs
reviewed
Jun 10, 2026
vados-cosmonic
force-pushed
the
fix(tests)=loosen-p3-async-http-content-length-acceptance-criteria
branch
3 times, most recently
from
2f915b1 to
7867ca7
Compare
This commit updates the test to allow for timings that match non-wasmtime implementations (i.e. Jco), which may not report the intermediate error (`ErrorCode::HttpProtocolError`) ahead of the "real" expected error (`ErrorCode::HttpRequestBodySize`)
vados-cosmonic
force-pushed
the
fix(tests)=loosen-p3-async-http-content-length-acceptance-criteria
branch
from
7867ca7 to
58d4aa7
Compare
alexcrichton
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the test to allow for timings that match non-wasmtime implementations (i.e. Jco), which may not report the intermediate error (
ErrorCode::HttpProtocolError) ahead of the "real" expected error (ErrorCode::HttpRequestBodySize)