[Rust] Look through typedefs to pass borrowed strings as &str
#1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wit-bindgen already knows to special-case passing strings by reference and pass them as
&strinstead of naively passing them as&Stringand requiring callers to have ownedStrings. Implement this behavior for type aliases of strings as well, so that in code like this:the argument is
&strinstead of&MyStringwhich is effectively&String. And similar for lists.This comes up in several functions in wasi-http; for example, in the bindings for the
Fields::appendfunction, it enables this change:where
FieldNameandFieldValueare defined as:pub type FieldKey = _rt::String; pub type FieldName = FieldKey; pub type FieldValue = _rt::Vec<u8>;