support "--with" parameter to include already generated types#1627
Open
cpetig wants to merge 1 commit into
Open
support "--with" parameter to include already generated types#1627cpetig wants to merge 1 commit into
cpetig wants to merge 1 commit into
Conversation
Collaborator
Author
|
I guess a test would be the ideal next step ... 🤔 The runner would import (half of) the exports by the test via a library, but this library design means that the test runner would need to run wit-bindgen twice for generating one component, also the test case linking becomes much more complex than now. I feel this is beyond the capabilities of the current test runner 🤔 |
Member
|
I think this would be best to have a test, yeah, and I agree the current infrastructure isn't sufficient to implement it. Would you be up for extending the test runner with support for this? It might make sense to reimplement the preexisting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements --with for C in a way similar to C++ (include) and Rust (external type path).