-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Add layoutDirection prop to TabView for RTL support
#494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmedawaad1804
wants to merge
8
commits into
callstack:main
Choose a base branch
from
ahmedawaad1804:support-rtl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5433e8f
feat: Add `layoutDirection` prop to `TabView` for iOS RTL support, in…
b478d2a
Update packages/react-native-bottom-tabs/ios/TabViewProvider.swift
ahmedawaad1804 8867d42
refactor: update layoutDirection prop to use 'locale' for consistency…
4977ddb
feat(android): add support for layout direction in ReactBottomNavigat…
8dc0c24
fix(iOS): enhance layout direction handling in NewTabView for better …
6602066
Update packages/react-native-bottom-tabs/ios/TabViewProps.swift
ahmedawaad1804 fa618ac
Update packages/react-native-bottom-tabs/ios/TabViewProvider.swift
ahmedawaad1804 016b48b
fix: update layoutDirection prop in FourTabsRTL to use 'rtl'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| import TabView, { SceneMap } from 'react-native-bottom-tabs'; | ||
| import React, { useState } from 'react'; | ||
| import { Article } from '../Screens/Article'; | ||
| import { Albums } from '../Screens/Albums'; | ||
| import { Contacts } from '../Screens/Contacts'; | ||
| import { Chat } from '../Screens/Chat'; | ||
| import { I18nManager, type ColorValue } from 'react-native'; | ||
|
|
||
| interface Props { | ||
| disablePageAnimations?: boolean; | ||
| scrollEdgeAppearance?: 'default' | 'opaque' | 'transparent'; | ||
| backgroundColor?: ColorValue; | ||
| translucent?: boolean; | ||
| hideOneTab?: boolean; | ||
| rippleColor?: ColorValue; | ||
| activeIndicatorColor?: ColorValue; | ||
| layoutDirection?: 'leftToRight' | 'rightToLeft'; | ||
| } | ||
|
|
||
| const renderScene = SceneMap({ | ||
| article: Article, | ||
| albums: Albums, | ||
| contacts: Contacts, | ||
| chat: Chat, | ||
| }); | ||
|
|
||
| export default function FourTabsRTL({ | ||
| disablePageAnimations = false, | ||
| scrollEdgeAppearance = 'default', | ||
| backgroundColor, | ||
| translucent = true, | ||
| hideOneTab = false, | ||
| rippleColor, | ||
| activeIndicatorColor, | ||
| layoutDirection = 'leftToRight', | ||
| }: Props) { | ||
| React.useLayoutEffect(() => { | ||
| if (layoutDirection === 'rightToLeft') { | ||
| I18nManager.allowRTL(true); | ||
| I18nManager.forceRTL(true); | ||
| } | ||
| return () => { | ||
| if (layoutDirection === 'rightToLeft') { | ||
| I18nManager.allowRTL(false); | ||
| I18nManager.forceRTL(false); | ||
| } | ||
| }; | ||
| }, [layoutDirection]); | ||
| const [index, setIndex] = useState(0); | ||
| const [routes] = useState([ | ||
| { | ||
| key: 'article', | ||
| title: 'المقالات', | ||
| focusedIcon: require('../../assets/icons/article_dark.png'), | ||
| unfocusedIcon: require('../../assets/icons/chat_dark.png'), | ||
| badge: '!', | ||
| }, | ||
| { | ||
| key: 'albums', | ||
| title: 'البومات', | ||
| focusedIcon: require('../../assets/icons/grid_dark.png'), | ||
| badge: '5', | ||
| hidden: hideOneTab, | ||
| }, | ||
| { | ||
| key: 'contacts', | ||
| focusedIcon: require('../../assets/icons/person_dark.png'), | ||
| title: 'المتراسلين', | ||
| badge: ' ', | ||
| }, | ||
| { | ||
| key: 'chat', | ||
| focusedIcon: require('../../assets/icons/chat_dark.png'), | ||
| title: 'المحادثات', | ||
| role: 'search', | ||
| }, | ||
| ]); | ||
|
|
||
| return ( | ||
| <TabView | ||
| sidebarAdaptable | ||
| disablePageAnimations={disablePageAnimations} | ||
| scrollEdgeAppearance={scrollEdgeAppearance} | ||
| navigationState={{ index, routes }} | ||
| onIndexChange={setIndex} | ||
| renderScene={renderScene} | ||
| tabBarStyle={{ backgroundColor }} | ||
| translucent={translucent} | ||
| rippleColor={rippleColor} | ||
| activeIndicatorColor={activeIndicatorColor} | ||
| layoutDirection={layoutDirection} | ||
| /> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.