feat: add motion tokens (spring, easing, duration)#4922
Open
adrcotfas wants to merge 1 commit into@adrcotfas/refactor/tokens_typographyfrom
Open
feat: add motion tokens (spring, easing, duration)#4922adrcotfas wants to merge 1 commit into@adrcotfas/refactor/tokens_typographyfrom
adrcotfas wants to merge 1 commit into@adrcotfas/refactor/tokens_typographyfrom
Conversation
|
Hey @adrcotfas, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
adrcotfas
force-pushed
the
@adrcotfas/refactor/tokens_typography
branch
from
919f3be to
8ce4e46
Compare
Adds theme.motion with two preset schemes (expressiveMotion default, standardMotion), M3 easing curves, and duration constants verified against the material.io spec. Includes toRawSpring() helper to convert the spec damping ratio to the raw coefficient expected by Animated.spring and Reanimated. Deprecates animation.defaultAnimationDuration in favour of theme.motion.duration.*. No component consumes the tokens yet.
adrcotfas
force-pushed
the
@adrcotfas/refactor/tokens_motion
branch
from
520d21e to
f1e1cf1
Compare
This was referenced May 5, 2026
satya164
requested changes
May 9, 2026
Member
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
No components are using this, so I assume it'll be a follow-up.
Comment on lines
+18
to
19
| /** @deprecated Use `theme.motion.duration.*` instead. Will be removed in a future version. */ | ||
| defaultAnimationDuration?: number; |
Member
There was a problem hiding this comment.
Drop deprecated values from theme.
| expressiveMotion, | ||
| standardMotion, | ||
| toRawSpring, | ||
| } from './theme/tokens/sys/motion'; |
Member
There was a problem hiding this comment.
Remove these exports. Keep the public API surface small.
Comment on lines
+52
to
+54
| legacy: [0.4, 0, 0.2, 1], | ||
| legacyAccelerate: [0.4, 0, 1, 1], | ||
| legacyDecelerate: [0, 0, 0.2, 1], |
Member
There was a problem hiding this comment.
Do we need to expose these? If these are legacy, then probably nothing on paper will use them, nor should consumers use them, so they're essentially dead tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds theme.motion with two preset schemes (expressiveMotion default, standardMotion), M3 easing curves, and duration constants verified against the material.io spec. Includes toRawSpring() helper to convert the spec damping ratio to the raw coefficient expected by Animated.spring and Reanimated. Deprecates animation.defaultAnimationDuration in favour of theme.motion.duration.*. No component consumes the tokens yet.
Related issue
See https://www.notion.so/callstack/React-Native-Paper-Foundation-for-MD3-Expressive-34c5d027c0f880edba3df107cd35946f?source=copy_link
Merge order:
Test plan
yarn typescript-- no new type errorsyarn test-- all tests pass