DPE-8980 Support Juju 4: use 'ip' instead of 'private-address' (if available)#1318
DPE-8980 Support Juju 4: use 'ip' instead of 'private-address' (if available)#1318taurus-forever merged 2 commits into16/edgefrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1318 +/- ##
========================================
Coverage 70.70% 70.70%
========================================
Files 16 16
Lines 4298 4298
Branches 691 691
========================================
Hits 3039 3039
Misses 1049 1049
Partials 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No quick win :-(
Need further investigation. No Juju Secret changes spotted in Juju 4 release notes |
|
It looks like Juju 4 doesn't allow the same Juju Secrets label for different units, while it used to work well in Juju 3.6: Juju 4 doesn't allow to create secret with label Branched to juju/juju#21344 |
|
The issue juju/juju#21344 has been fixed, and now PostgreSQL cluster can be deployed. Reproducer: |
c74220e to
0eaa264
Compare
…ddress') The Juju 4 has removed support databag fiesl `private-address`, `ingress-address` and more. The field we should use is `ip` now. The PG16 charm still have to support Juju 3.6 LTS, so adding support of the ip field with backward compatibility. Users can deploy it on Juju 4 using: > juju deploy postgresql --channel 16/edge --force
0eaa264 to
7cb787e
Compare
…ailable) (#1318) * DPE-8980 Support Juju 4: us 'ip' databag field (overwrites 'private-address') The Juju 4 has removed support databag fiesl `private-address`, `ingress-address` and more. The field we should use is `ip` now. The PG16 charm still have to support Juju 3.6 LTS, so adding support of the ip field with backward compatibility. Users can deploy it on Juju 4 using: > juju deploy postgresql --channel 16/edge --force * Address comments in PR

Issue
No Juju 4 support by the charm.
Solution
The Juju 4 has removed support databag fiesl
private-address,ingress-addressand more. The field we should use isipnow. The PG16 charm still have to support Juju 3.6 LTS, so adding support of the ip field with backward compatibility.We are not going to allow Juju 4 deployments (assume in metadata.yaml),
however users can use the following command to test Juju 4: