fix!: use distinct names for label props and slots (svelte 5 fix) #2408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spburtsev
force-pushed
the
distinct-label-children
branch
from
8b57958 to
3806960
Compare
metonym
force-pushed
the
distinct-label-children
branch
from
0bd66da to
800af90
Compare
metonym
force-pushed
the
distinct-label-children
branch
from
800af90 to
cc3c9ef
Compare
metonym
approved these changes
Dec 7, 2025
Collaborator
There was a problem hiding this comment.
Nice work! Thanks for fixing this papercut. My thoughts:
- Scope: This solves a TypeScript issue with using
#snippetwith Svelte 5. No runtime issues, andslotcan still be used. It's acceptable to make a breaking change, since downstream impact is minimal (should be a one-line change). - Naming: I like the
prefix<Children>pattern.childrenis now a reserved prop in Svelte 5, but I think the pattern is semantic. I'd also consideredprefix<Slot>, but "slots" are already legacy. - Other shadowed prop names: There are other shadowed prop names; I've created these as sub-issues of #2105.
I added more test coverage for named slots in #2410.
I rebased on master and grouped related changes into their distinct commits.
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2411, supports #2105
Breaking changes:
labelTextslot renamed tolabelChildrento resolve Svelte 5 errors when passing snippetsIn Svelte 5, having both a
labelTextprop andlabelTextslot causes the static analyzer to flag errors when using snippet syntax. Renaming the slot eliminates this error and creates a clearer distinction between text-only labels (prop) and rich content labels (slot/snippet).