Skip to content

CFE-4661: Fixed an issue where wrong names in --clients would cause cf-remote to hang #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarakthon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CFE-4661: Fixed an issue where wrong names in --clients would cause cf-remote to hang #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b17a8d
Fix spelling
sarakthon Jun 5, 2026
c8f7d6a
CFE-4661: cf-remote hangs when specifying wrong names in --clients
sarakthon Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions cf_remote/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import argparse
import os
import sys
import re
import socket

from cf_remote import log
from cf_remote import version
Expand Down Expand Up @@ -504,7 +506,7 @@ def validate_command(command, args):
if command in ["sudo", "run"]:
if len(args.remote_command) != 1:
raise CFRExitError(
"cf-remote sude/run requires exactly 1 command (use quotes)"
"cf-remote sudo/run requires exactly 1 command (use quotes)"
)
args.remote_command = args.remote_command[0]

Expand Down Expand Up @@ -613,6 +615,13 @@ def get_cloud_hosts(name, bootstrap_ips=False):
return ret


def dns_lookup(name):
try:
return bool(socket.getaddrinfo(name, 22))
except socket.gaierror as e:
raise CFRUserError("DNS lookup failed for '{}': {}".format(name, e))


def resolve_hosts(string, single=False, bootstrap_ips=False):
log.debug("resolving hosts from '{}'".format(string))
if is_file_string(string):
Expand All @@ -627,8 +636,12 @@ def resolve_hosts(string, single=False, bootstrap_ips=False):
hosts = get_cloud_hosts(name, bootstrap_ips)
ret.extend(hosts)
log.debug("found in cloud, adding '{}'".format(hosts))
else:
elif name.startswith("@"):
raise CFRUserError("'{}' does not exist.".format(name))
elif re.search(r"[@:.]", name) or dns_lookup(name):
ret.append(name)
else:
raise CFRUserError("'{}' does not exist.".format(name))

if single:
if len(ret) != 1:
Expand Down
Loading