linting fixes#599
Draft
flacoman91 wants to merge 4 commits into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
fixing lint warnings and code improvements
add lit to peerDependencies so other projects using WC won't fail for not including lit. I opened a ticket here for DS: DS should install lit as a dependency design-system#2691
fixed font issue to make sure source sans loads in storybook & library builds.
src/index.tsalready imports the font for library consumers; the Storybook preview entry was missing the same import (documented in_shared.scssbut not implemented).declare module for font to fix ts lint nag (Fontsource ships CSS only, no
.d.ts)Storybook typing fixes Storybook’s
StoryObj<typeof meta>inference breaks when storyargsdon’t match the metacomponenttype, or when component props are a discriminated union. Updated affected stories to use the correct component type forStoryObj.src/index.tsalready imports the font for library consumers; the Storybook preview entry was missing the same import (documented in_shared.scssbut not implemented).eslint.config.js- Ignore.yarn/**sonpx eslint .does not fail on the Yarn release bundleupdated
README.md| Update install instructions to include peer dependencies and note whylitis needed |Notes
litpeer dependency is a workaround until@cfpb/cfpb-design-systemdeclareslitin its ownpackage.json(packaging bug filed separately).