Add oxlint to the repo#102
Conversation
|
@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel. A member of the Team first needs to authorize it. |
| "categories": { | ||
| "correctness": "error", | ||
| "suspicious": "error", | ||
| "perf": "error", | ||
| "pedantic": "error" | ||
| }, |
There was a problem hiding this comment.
I haven’t enabled the style and restrictions categories yet to keep the review scope lighter.
Let me know if you’d like me to include them.
I can either add them in this PR or follow up with a separate one, whichever you prefer.
There was a problem hiding this comment.
I don't know what style would bring to the table over just relying on the formatter.
As to restrictions, I briefly looked through the list and some of those rules seem to be useful while some doesn't so perhaps we should try to enable that and turn off specific rules we don't like. I'll try to make a pass through this to assess which ones we want.
There was a problem hiding this comment.
I don't know what style would bring to the table over just relying on the formatter.
Actually I find some of the style rules, like typescript/consistent-type-imports, pretty useful.
I would consider give some of them a go, but we we can do it later
As to restrictions, I briefly looked through the list and some of those rules seem to be useful while some doesn't so perhaps we should try to enable that and turn off specific rules we don't like. I'll try to make a pass through this to assess which ones we want.
Sure, I'll focus on addressing your other feedbacks for now.
|
Thanks for the thought review! |
|
@Andarist I applied all your changes (I hope 😅). |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2 participants
Alongside adding
oxlintI also updatedtypescriptto the latest version