Assert that run_connection_attempts does not break out of the loop with connection attempts left to try - #8459
Open
link2xt wants to merge 3 commits into
Open
Assert that run_connection_attempts does not break out of the loop with connection attempts left to try#8459link2xt wants to merge 3 commits into
link2xt wants to merge 3 commits into
Conversation
link2xt
marked this pull request as ready for review
July 24, 2026 20:06
hpk42
reviewed
Jul 30, 2026
| all_errors.push(err); | ||
| } | ||
| Err(err) => { | ||
| break Err(err); |
Contributor
There was a problem hiding this comment.
doesn't this breaking out effectively discard all_errors and remaining candidates are ignored?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is a JoinError (see https://docs.rs/tokio/latest/tokio/task/struct.JoinSet.html#method.join_next) which means the task was cancelled (we never do it, we do not save the result of connection_attempt_set.spawn()) or panicked. So this is error should never happen, if it does everything will be cancelled with a "Failed to join task" error returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added basic test and updated the comment.