Harden flaky test E2E coverage#1346
Open
thebiglabasky wants to merge 4 commits into
Open
Conversation
…o herve/harden-flaky-test-e2e # Conflicts: # packages/cli/e2e/__tests__/test.spec.ts # packages/cli/src/constructs/__tests__/fixtures/api-check/test-cases/test-skip-ssl/test.check.js
thebiglabasky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Skip SSL Checkfixture API check instead of removing it, so a deploy can pause the existing Checkly resource without deleting it.checkly testE2E smoke run with--grep, sincecheckly teststill bundles matching inactive checks for ad-hoc execution.secret.check.tsso reporter assertions are not coupled to unrelated fixture checks.skipSSL: trueis synthesized without relying onbadssl.comduring E2E runs.Why
The failing E2E depended on
https://self-signed.badssl.com/, which can reset connections from Checkly cloud runners. That made a broad CLI smoke test and the GitHub reporter test fail for reasons unrelated to the behavior they are intended to cover.Validation
pnpm exec vitest --run ./src/constructs/__tests__/api-check.spec.tspnpm exec eslint e2e/__tests__/test.spec.ts src/constructs/__tests__/api-check.spec.tspnpm run linton staged filesI did not run the remote E2E suite locally because this shell does not have
CHECKLY_API_KEY/CHECKLY_ACCOUNT_IDconfigured.