Expose read-latency and write-latency parameters of FIRRTL memories #5133
+383
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmckay
commented
Dec 24, 2025
| Seq.fill(numReadPorts)(clock), | ||
| Seq.fill(numWritePorts)(clock), | ||
| Seq.fill(numReadwritePorts)(clock), | ||
| 1, |
Contributor
Author
There was a problem hiding this comment.
Summary of the changes in this file:
- Add
readLatencyandwriteLatencyto the private impl functions - For each public API
- Set the default latency of 1
- Add a copy of that method with latency parameters passed by the caller
If we expose additional parameters in the future, I think we can keep the minimal public APIs that were present before this PR, then add additional parameters to the new APIs added here.
seldridge
approved these changes
Jan 6, 2026
| * | ||
| * @return A new `SRAMInterface` wire containing the control signals for each instantiated port | ||
| * @note This does *not* return the `SyncReadMem` itself, you must interact with it using the returned bundle | ||
| * @note Read-only memories (R >= 1, W === 0, RW === 0) and write-only memories (R === 0, W >= 1, RW === 0) are not supported by this API, and will result in an error if declared. |
Member
There was a problem hiding this comment.
The more Scaladoc way of doing this is:
@throws java.lang.IllegalArgumentException if <the user does something>
mikeurbach
approved these changes
Jan 6, 2026
Contributor
mikeurbach
left a comment
mikeurbach
left a comment
There was a problem hiding this comment.
Nice, looks good to me
jackkoenig
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
read-latencyandwrite-latency>= 1Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.