Skip to content

add wasm-bindgen conversion impls to Datetime #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demhadais wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add wasm-bindgen conversion impls to Datetime #1750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions src/datetime/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1965,6 +1965,53 @@ impl From<DateTime<Utc>> for js_sys::Date {
}
}

#[cfg(all(
Copy link
Member

@djc djc Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this verbose, suggest wrapping these in a module, like so:

#[cfg(all(
    target_arch = "wasm32",
    feature = "wasmbind",
    not(any(target_os = "emscripten", target_os = "wasi", target_os = "linux"))
))]
mod wasm_impls {
    use wasm_bindgen::convert::{FromWasmAbi, ..};

    impl .. { }

    // etc
}

target_arch = "wasm32",
feature = "wasmbind",
not(any(target_os = "emscripten", target_os = "wasi", target_os = "linux"))
))]
mod wasm_impls {
use crate::{DateTime, Utc};

impl wasm_bindgen::convert::FromWasmAbi for DateTime<Utc> {
type Abi = <js_sys::Date as wasm_bindgen::convert::FromWasmAbi>::Abi;
unsafe fn from_abi(js: Self::Abi) -> Self {
unsafe { js_sys::Date::from_abi(js).into() }
}
}

impl wasm_bindgen::convert::IntoWasmAbi for DateTime<Utc> {
type Abi = <js_sys::Date as wasm_bindgen::convert::IntoWasmAbi>::Abi;
fn into_abi(self) -> Self::Abi {
js_sys::Date::from(self).into_abi()
}
}

impl wasm_bindgen::describe::WasmDescribe for DateTime<Utc> {
fn describe() {
js_sys::Date::describe()
}
}

impl wasm_bindgen::describe::WasmDescribeVector for DateTime<Utc> {
fn describe_vector() {
js_sys::Date::describe_vector()
}
}

impl wasm_bindgen::convert::OptionFromWasmAbi for DateTime<Utc> {
fn is_none(abi: &Self::Abi) -> bool {
js_sys::Date::is_none(abi)
}
}

impl wasm_bindgen::convert::OptionIntoWasmAbi for DateTime<Utc> {
fn none() -> Self::Abi {
js_sys::Date::none()
}
}
}

// Note that implementation of Arbitrary cannot be simply derived for DateTime<Tz>, due to
// the nontrivial bound <Tz as TimeZone>::Offset: Arbitrary.
#[cfg(all(feature = "arbitrary", feature = "std"))]
Expand Down