Skip to content

Phase 6A: remove retained PAT shadows from develop workflows#1196

Open
ihalatci wants to merge 1 commit into
developfrom
migrate/develop-drop-pat-shadow
Open

Phase 6A: remove retained PAT shadows from develop workflows#1196
ihalatci wants to merge 1 commit into
developfrom
migrate/develop-drop-pat-shadow

Conversation

@ihalatci

@ihalatci ihalatci commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Phase 6A: remove the retained dead secrets.GH_TOKEN top-level env: shadow line from 6 already-migrated workflows (pure deletions, one line per file):

  • build-package.yml, build-package-test.yml, image-health-check.yml (quoted shadow removed)
  • build-citus-community-nightlies.yml, build-pgazure-nightlies.yml, update-pgxn-version.yml (unquoted shadow removed)

Rationale: each of these workflows now mints its own GitHub App token via actions/create-github-app-token@v3 and exports it to $GITHUB_ENV, so the top-level PAT shadow was unused; the org PAT secrets.GH_TOKEN is retired/dead. diff --stat = 6 files changed, 6 deletions(-), 0 insertions(+); grep secrets.GH_TOKEN across .github/workflows/ = 0 matches.

Validation (push-triggered on 3869af0, all success):

  • Build Package — run 28934598464 — success
  • Build package for test images — run 28934598467 — success
  • Image Health Check — run 28934598520 — success
  • Build and publish citus community nightly packages — run 28934598492 — success
  • build-pgazure-nightlies (disabled_manually) and update-pgxn-version (workflow_dispatch-only) did not fire — expected.

MERGE HELD — draft for review. No merge, no auto-merge.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ihalatci ihalatci marked this pull request as ready for review July 8, 2026 16:26
@ihalatci ihalatci enabled auto-merge (squash) July 8, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants