Phase 6A: remove retained PAT shadows from develop workflows#1196
Open
ihalatci wants to merge 1 commit into
Open
Phase 6A: remove retained PAT shadows from develop workflows#1196ihalatci wants to merge 1 commit into
ihalatci wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6A: remove the retained dead
secrets.GH_TOKENtop-levelenv:shadow line from 6 already-migrated workflows (pure deletions, one line per file):build-package.yml,build-package-test.yml,image-health-check.yml(quoted shadow removed)build-citus-community-nightlies.yml,build-pgazure-nightlies.yml,update-pgxn-version.yml(unquoted shadow removed)Rationale: each of these workflows now mints its own GitHub App token via
actions/create-github-app-token@v3and exports it to$GITHUB_ENV, so the top-level PAT shadow was unused; the org PATsecrets.GH_TOKENis retired/dead.diff --stat= 6 files changed, 6 deletions(-), 0 insertions(+); grepsecrets.GH_TOKENacross.github/workflows/= 0 matches.Validation (push-triggered on
3869af0, all success):MERGE HELD — draft for review. No merge, no auto-merge.