Refactor functions to use SPI instead of heap specific functions#435
Open
za-arthur wants to merge 1 commit into
Open
Refactor functions to use SPI instead of heap specific functions#435za-arthur wants to merge 1 commit into
za-arthur wants to merge 1 commit into
Conversation
Functions `cron_unschedule`, `cron_unschedule_named`, `LoadCronJobList` used heap specific functions to select or modify records which fails if pg_cron tables are created using table access method other than `heap`.
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions
cron_unschedule,cron_unschedule_named,LoadCronJobListused heap specific functions to select or modify records which fails if pg_cron tables are created using table access method other thanheap.This PR refactors that functions to use SPI (similar to other places like
ScheduleCronJob) instead of direct call ofsystable_beginscanandsimple_heap_deletefunctions, which are heap specific.There are few
systable_beginscancalls left which are used to scan system tables, but this is intentional.