scaleset: replace deleted runners - #843
Draft
rm-you wants to merge 1 commit into
Draft
Conversation
Refresh scale set instances from the database so missed watcher updates cannot strand deleted rows in the capacity count. Mark verified GitHub scale sets as created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted instances remained in the scale set worker's runner count until cleanup completed. A deleted idle runner could therefore satisfy min_idle_runners and prevent its replacement from being created. The scale set could also remain in pending_create after successful initialization.
Refresh the worker cache from the database before autoscaling, remove deleted rows, exclude instances already being deleted from capacity, and mark an initialized scale set as created. Pending-create instances still count, preventing duplicate replacements, and max_runners remains enforced.
Tests cover deletion states, stale cache reconciliation, single replacement creation, pending-create deduplication, maximum capacity, and the scale-set state transition.