Cover the non transcoding stream option in the SystemTextJson JsonEventFormatter unit test#349
Open
erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Open
Cover the non transcoding stream option in the SystemTextJson JsonEventFormatter unit test#349erwinkramer wants to merge 1 commit intocloudevents:mainfrom
erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Conversation
Signed-off-by: Erwin <erwinkramer@hotmail.com>
Contributor
|
I'm going to sit on this for a while - because I think there's value in targeting .NET 4.8 (using a Windows runner) in general. That would give me more confidence that the whole set of libraries works in .NET 4.8 than just relying on this "make sure we test this code path" approach. But if I can't get that to work, we can fall back on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure to cover the non-transcoding path.
This is a follow up of #342
I considered targeting
netstandard2.0for the unit tests but that seemed to be much more work and out of proportions for this scenario.