IMAGES-2229: Add tracing spans for hosted images RPC operations - #6957
Open
Monark-Arkmon wants to merge 1 commit into
Open
IMAGES-2229: Add tracing spans for hosted images RPC operations#6957Monark-Arkmon wants to merge 1 commit into
Monark-Arkmon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds user tracing spans to env.IMAGES.hosted.* (images_fetch, images_details, images_update, images_delete, images_upload, images_list). These calls go over JS RPC rather than fetch(), which is why they had no spans until now.
withSpan can now wrap a direct RPC method call and still close correctly, so the same instrumentation already used for the fetch()-based images_output and images_info spans now applies here too.