Skip to content

WOR-1487: expose workflow instance location hints - #6961

Open
Caio-Nogueira wants to merge 1 commit into
mainfrom
WOR-1487
Open

WOR-1487: expose workflow instance location hints#6961
Caio-Nogueira wants to merge 1 commit into
mainfrom
WOR-1487

Conversation

@Caio-Nogueira

Copy link
Copy Markdown
Contributor

Add the location hint option to the public and internal Workflow instance creation declarations.

@ask-bonk

ask-bonk Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

The apac-ne/apac-se sub-regions come from the generated RTTI for DurableObjectLocationHint (C++ source), not from defines/. This is a separate type defined in C++, so the difference is by design -- the Workflow type is a separate hand-written definition.

This PR looks clean. The changes are:

  1. Purely additive (new optional type + optional field)
  2. Backward-compatible
  3. Consistent across all 6 files
  4. No security concerns (type declarations only)
  5. No behavioral changes requiring compat flags

LGTM

github run

@codspeed-hq

codspeed-hq Bot commented Aug 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing WOR-1487 (dfec943) with main (343766b)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Add the location hint option to the public and internal Workflow
instance creation declarations.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.48%. Comparing base (d900d79) to head (dfec943).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6961      +/-   ##
==========================================
- Coverage   68.52%   68.48%   -0.04%     
==========================================
  Files         438      438              
  Lines      130004   130176     +172     
  Branches    21404    21424      +20     
==========================================
+ Hits        89079    89150      +71     
- Misses      27900    27987      +87     
- Partials    13025    13039      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants