Skip to content

emit per-call jsRpcCall spans and propagate stub origin for trace continuity - #6966

Closed
apeacock1991 wants to merge 2 commits into
mainfrom
apeacock/jsrpcTracing
Closed

emit per-call jsRpcCall spans and propagate stub origin for trace continuity#6966
apeacock1991 wants to merge 2 commits into
mainfrom
apeacock/jsrpcTracing

Conversation

@apeacock1991

Copy link
Copy Markdown
Contributor

Imported from #6750

Summary

Add per-call tracing for JavaScript RPC.

Changes

  • Emit jsRpcCall spans on both caller and callee.
  • Tag spans with the RPC method, operation, and target kind.
  • Parent the callee onset to the call that opened the session.
  • Add jsrpc.caller_span_id to correlate each callee dispatch with its caller.
  • Preserve tracing relationships for pipelined calls, returned stubs/promises, and callbacks.
  • Avoid retaining span state on untraced paths.

Testing

  • Added streaming-tail tests for pipelined RPC calls.
  • Added coverage for callback argument tracing.
  • Updated existing tail-worker tracing expectations.

Screenshots

image

@apeacock1991
apeacock1991 requested review from a team as code owners August 11, 2026 10:52
@apeacock1991 apeacock1991 changed the title Apeacock/jsrpc tracing emit per-call jsRpcCall spans and propagate stub origin for trace continuity Aug 11, 2026
@ask-bonk

ask-bonk Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@apeacock1991
apeacock1991 requested a review from mar-cf August 11, 2026 10:53
@ask-bonk

ask-bonk Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

1 similar comment
@ask-bonk

ask-bonk Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@apeacock1991 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.12%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
bm_Promise_Fib10 20.3 µs 18.5 µs +10.12%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing apeacock/jsrpcTracing (477f106) with main (c15dd17)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@apeacock1991
apeacock1991 force-pushed the apeacock/jsrpcTracing branch 2 times, most recently from ab1f81b to 5583e9d Compare August 13, 2026 16:24
@apeacock1991

Copy link
Copy Markdown
Contributor Author

Closing as rthe branch name didn't match internal

@apeacock1991
apeacock1991 deleted the apeacock/jsrpcTracing branch August 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants