Remove obsolete Cache PUT serialization - #6984
Open
guybedford wants to merge 1 commit into
Open
Conversation
Unknown-length Cache API PUTs are serialized even though the runtime quota that required ordering was removed. Concurrent puts of cloned response bodies can deadlock when tee backpressure prevents the first body from completing before the second starts. Allow these requests to start concurrently and add a regression test.
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@guybedford Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
danlapid
approved these changes
Aug 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
==========================================
- Coverage 68.50% 68.46% -0.04%
==========================================
Files 438 438
Lines 130173 130193 +20
Branches 21423 21417 -6
==========================================
- Hits 89169 89132 -37
- Misses 27964 28029 +65
+ Partials 13040 13032 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
APIError: Invalid Anthropic API Key |
5 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes obsolete Cache API PUT stream serialization, preventing a deadlock when concurrent
cache.put()calls consume clones of the same unknown-lengthResponse.The serializer originally accounted for the aggregate runtime Cache PUT quota. That quota was removed in 2024, but the ordering remained. Since cloned response bodies apply tee backpressure, the first PUT can wait for the second branch while the second PUT waits for the first to release the serializer.
TransformStreamresponse bodies.Tested with all generated regression variants, ESLint, and the existing Cache API suite.