Skip to content

Don't use threads to prevent 'isolation: :truncation' #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippthun merged 1 commit into from
Jan 16, 2026
Merged

Don't use threads to prevent 'isolation: :truncation' #4781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions spec/unit/lib/cloud_controller/diego/tasks_sync_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,30 @@ module Diego
end
end

context 'when a running CC task is missing from BBS', isolation: :truncation do
# Can't use transactions for isolation because we're using multiple threads
context 'when a running CC task is missing from BBS' do
let!(:running_task) { TaskModel.make(:running, created_at: 1.minute.ago) }
let!(:canceling_task) { TaskModel.make(:canceling, created_at: 1.minute.ago) }
let!(:start_event_for_running_task) { AppUsageEvent.make(task_guid: running_task.guid, state: 'TASK_STARTED') }
let!(:start_event_for_canceling_task) { AppUsageEvent.make(task_guid: canceling_task.guid, state: 'TASK_STARTED') }
let(:bbs_tasks) { [] }

before do
# Don't use threads in this spec as it would require the use of 'isolation: :truncation' which is slow
class InlineWorkPool
def submit(*args, &block)
block.call(*args)
end

def drain; end

def exceptions
[]
end
end

allow(WorkPool).to receive(:new).and_return(InlineWorkPool.new)
end

it 'marks the tasks as failed' do
subject.sync

Expand Down