chore: add blog post about building images with bake#314
Conversation
f5b346c to
185c20c
Compare
jsilvela
left a comment
There was a problem hiding this comment.
Great content.
Some of the paragraphs are rather complicated.
I've made some grammar fixes.
And, on line length: very far from 80, though that is a conversation I always wonder if we're having.
Javex
left a comment
There was a problem hiding this comment.
Unfortunately I got stuck on the step to actually build the image so I wasn't able to review the rest of the instructions yet. Thank you for writing it up so quickly! If I understanding everything correctly so far it should be pretty straightforward to based my custom bake file on your upstream one, that's pretty awesome.
jsilvela
left a comment
There was a problem hiding this comment.
Made a bunch of corrections, and have been breaking up paragraphs with lots of commas to use stops instead.
I think it looks OK, but probably worth another round of simplification.
|
did anybody manage to " the local file is not found the |
using |
jsilvela
left a comment
There was a problem hiding this comment.
OK, the post is IMO still not ready.
Still grammar issues and clunky wording. Here are a bunch of suggestions.
|
Thank you again for writing this up. I managed to get it worked and understood the instructions in the remainder of the post. Unfortunately, I discovered that renovate doesn't support bake yet (renovatebot/renovate#33463) which means I couldn't automate creating a fresh docker image whenever you release a new one upstream. For now I think I'll stick with my current solution of just inheriting using |
That will not work indeed, since the problem is that inline is a temporary context. My advice will be create another target and do the inheritance from that and use that in a local context to build the container, meaning that first target will be remote and the final one will be local |
|
When updating from an old school built 17.4 image to the bake 17.5 I receive this error when I fenced the instance and had a look into /usr/lib/postgresql there are binaries for versions 16 and 17. this is the bake.hcl file When I spin up a fresh cluster with the bake built 17.5 image, I receive an error that the pg_cron file is missing. looking inside the image, pg_cron is there not sure how to continue troubleshooting this? |
jsilvela
left a comment
There was a problem hiding this comment.
Just read this again, and I have more comments.
|
I've not applied the 80 characters-thing, let's do that once we're happy with the text? |
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@mailfence.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Thank you Jaime! Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
a85e7e7 to
551c96a
Compare
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
| By default, we build the images for `amd64` and `arm64` architectures, which is the recommended approach for most users. | ||
| However, if you want to build images for your specific architecture and so, saving some space, you can override the | ||
| `platforms` variable in your local Bake file. | ||
|
|
There was a problem hiding this comment.
By default, images are built for both amd64 and arm64 architectures, which is the recommended setup for most users. However, if you want to target a specific architecture and reduce image size, you can override the platforms variable in your local Bake file.
@smiyc This is totally unrelated, this sounds more like an issue that pg_cron is never installed either in the base or the new layer, but if you want send me a message on Slack and we do the troubleshooting there if you don't fix it already, sorry this was a blog post didn't saw this :D thank to @FloorD for telling me to look into this :D |
jsilvela
left a comment
There was a problem hiding this comment.
OK, this passes muster.
I have left a few optional comments ... well the last one is a little less optional. Anyway.
And, on the 80 columns limit.
Let's be consistent about it. I'd be open to abandoning that. Formatting for 80 col does get a bit silly.
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
No description provided.