Open
Conversation
robkooper
reviewed
Feb 20, 2023
| "agent": { | ||
| "@type": "cat:extractor", | ||
| "extractor_id": host + "/api/extractors/ncsa.image.metadata" | ||
| if float(clowder_version) >= 2.0: |
Member
There was a problem hiding this comment.
would it make sense to use the same function here? I assume the self.get_metadata returns the same object? same for #29. If leverage of that, we don't need the CLOWDER_VERSION above either.
Author
There was a problem hiding this comment.
Fixed for both pull requests. You are right - the method will work either way and then there's no need to check clowder version here, it'll be done on the pyclowder side.
Author
There was a problem hiding this comment.
For the metadata and v1, this branch of pyclowder:
clowder-framework/pyclowder#60
Allows the context to be passed to the get_metadata so that the method can be used for both instead of this call.
no need for explicit metadata construction with either version
lmarini
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this branch, use this branch of pyclowder:
https://github.com/clowder-framework/pyclowder/tree/59-change-context-type-for-v2
Also, use environment variable CLOWDER_VERSION=2.0
Then this should work with clowder v2. The method for generating metadata has changed.