[pull] master from cube-js:master#592
Merged
Merged
Conversation
…1232) The SQL API streaming path shipped rows across the JS->Rust native bridge as an array of row objects and rebuilt each `RecordBatch` cell-by-cell through per-cell Neon/NAPI downcasts (`JsValueObject::get`). This mirrors the row-oriented transport the `/load` path already replaced with a columnar JSON `Buffer`. ## Benchmark Measured on a local Postgres (Docker) with a pre-loaded 10M-row `orders` table, streaming the **ungrouped** result through the SQL API to `psql`, so the data source is not the bottleneck (server-side seq-scan ≈ 0.3s). **Server-side** = Cube `Load Request` duration (the streaming pipeline itself). The dimension-width axis mirrors our k6 benchmark (`status, user_id, product_id` + `dim1..dimN`). ### 10M rows | dims | master (row + per-cell NAPI) | this PR (columnar + JSON) | speedup | |-----:|-----------------------------:|--------------------------:|--------:| | 3 | 18.2s | 12.4s | 1.47× | | 8 | 37.9s | 23.9s | 1.58× | | 16 | 65.9s | 42.7s | 1.54× | | 32 | 173.6s | 98.7s | 1.76× | ### 2M rows | dims | master | this PR | speedup | |-----:|-------:|--------:|--------:| | 3 | 4.0s | 2.4s | 1.68× | | 8 | 7.5s | 4.9s | 1.53× | | 16 | 13.1s | 9.1s | 1.44× | | 32 | 34.3s | 19.9s | 1.72× |
* docs: document the new tab page launchpad and default view group setting (CUB-2304) * docs: document the new tab page launchpad and its settings * docs: address review — add workbooks/data-sources/REST/GraphQL links, drop redundant lines, fix reader address * docs: use Explore (not Explorer) and link to the Explore page * docs: fold new tab page into workbooks page between Tabs and Tab types; drop standalone page * docs: add New tab page section to workbooks page and drop its nav entry * CUB-2304: drop certified queries from the new-tab launchpad docs * docs: update launchpad section for disabled no-match tabs and query-reuse framing
github-actions
Bot
added
pr:community
rust
data source driver
driver:pinot
javascript
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )