[pull] master from cube-js:master#604
Merged
Merged
Conversation
…ing S3 requests (#11278) * fix(cubestore): send x-amz-server-side-encryption only on object-storing S3 requests CUBESTORE_S3_SSE previously attached the header via rust-s3 bucket-wide extra_headers, which merges it into every request. S3 rejects the header on read/list operations, returning an error XML that list parsing fails on ('serde xml: missing field Name') — crash-looping the metastore loader on startup. The header is now applied per-operation inside the rust-s3 fork (PutObject / InitiateMultipartUpload only; UploadPart inherits the encryption declared at initiation). Bumps the fork rev to the tip of cube-js/rust-s3#2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cubestore): exclude streaming part uploads from the SSE header (fork rev bump) put_object_stream issues parts as PutObject{multipart:Some}, which the previous fork rev still stamped with x-amz-server-side-encryption — S3 rejects it on parts (HTTP 400), breaking multipart uploads (observed on a 210MB metastore WAL). Bumps cube-js/rust-s3#2 to b586c38. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(cubestore): pin rust-s3 to merged cubestore-0.32.3-backport tip (9deb3475) cube-js/rust-s3#2 merged; fix verified e2e on the affected BYOC cluster (210MB metastore WAL multipart upload + pre-agg builds green with CUBESTORE_S3_SSE=AES256 under the customer's SCP). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )