[pull] main from microsoft:main#1495
Merged
Merged
Conversation
Only arm protocol disconnect timeouts for clients that this server has observed disconnecting. Unknown client IDs may belong to local IPC and must remain pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Include the required turn start timestamp after updating the branch to current main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Include statically named dynamic imports in the remote Agent Host dependency graph while excluding exact dev-only and test-only imports. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Stream agent host debug logs into export instead of buffering
The "Export Agent Host Debug Logs" action read every log file fully into
a JS string and shipped those strings across IPC to build the zip. This
now passes lazy {resource, size} references and streams a bounded prefix
of each file straight from disk into the archive.
To make streaming robust, zip() re-stats the local file just before
reading and clamps the streamed prefix to the file's current size, so a
log that was rotated or truncated after its size was captured (e.g. while
the save dialog was open) still produces a valid entry instead of
aborting the whole archive; a file that vanished is skipped.
(Written by Copilot)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Address Copilot review: robust streaming, per-file isolation, docs
- zip(): open a single file handle per streamed entry and derive both the
declared size and the bytes from that same descriptor, so rotation or
truncation of the path can't trip yazl's byte-count assertion. Wire the
output pipe/error handling before adding entries so a read-stream error
during a later awaited open can't become an uncaught exception. Only skip
ENOENT; surface other open errors.
- collectAgentHostDebugLogs(): wrap remote Copilot log reads per file so one
rotated/removed log warns and is skipped instead of failing the whole
export.
- createDebugLogFile(): when a captured size is known for a non-local
resource, read only that prefix (readFileStream({ length })) to keep the
allocation bounded.
- native.ts: document the streamed INativeZipFile variant on createZipFile.
- Add a zip test for skipping a vanished streamed source.
(Written by Copilot)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Trim verbose inline comments
Keep the non-obvious rationale (yazl byte-count constraint, handle
ownership) but drop the over-explanation.
(Written by Copilot)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* chat: make archived agent sessions read-only (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: track read-only state after session creation Keep newly materialized Agent Host sessions subscribed to archive and interactivity state without requiring the chat to be reopened.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: fix read-only session lifecycle Attach archive state after both direct and eager session materialization, avoid rewiring source sessions during forks, and keep archive dispatch ownership in the existing controller.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: address archived read-only review feedback Rebind materialized read-only sessions before rejecting sends, preserve focus for empty read-only chats, and cover chat interactivity transitions.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: clarify archived session banner Use the archived-session wording from the Agents window in editor chat surfaces.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Remove deprecated notebook output settings and migration Removes the deprecated notebook output settings (notebook.outputLineHeight, notebook.outputFontSize, notebook.outputFontFamily, notebook.experimental.outputScrolling) and their one-time migration logic. These were deprecated in Feb 2023 in favor of the notebook.output.* keys and are no longer registered in the configuration schema, so only the migration code referenced them. Refs #326491 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove stale temporary-fix comment reference in extHostNotebook Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* sessions: Reset branch picker when switching workspaces Do not carry repository-scoped branch choices into new workspaces. Preserve selected branches during config resolution while showing local branch names and retaining remote refs as worktree start points.\n\nFixes #323468.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Separate default branch name from start point Return structured default-branch information so UI and API consumers use the local branch name while worktree creation uses the appropriate Git start point without parsing remote prefixes.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Keep explicit default branch return types Restore explicit return type annotations on Agent Host Git service test doubles.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: Address branch picker review feedback Wait for config resolution deterministically in the provider test and cover default branch name/start-point behavior with real Git repositories.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…imeout agentHost: preserve local IPC tool calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )