[pull] main from adobe:main#426
Merged
Merged
Conversation
The empty state example for S2 TableView had two `- begin highlight -` markers around a single block (one before `<TableBody>` and a second, redundant one inside the opening tag) but only one `- end highlight -`. The code highlighter in `Code.tsx` (`lines()`) starts a new highlight grouping on each `begin` marker and resets the current line, with no guard for an already-open grouping. The second `begin` therefore discarded the already-accumulated `<TableBody` line, so the rendered example (and the StackBlitz/copy/download export, which reads the same rendered code) was missing the `<TableBody>` opening tag, producing invalid JSX. Removing the redundant inner marker leaves the canonical single begin/end pair so the full `<TableBody ... renderEmptyState>` tag renders and the example compiles in StackBlitz. Closes #10231 Co-authored-by: Patrick Wehbe <patrick.wehbe.applications@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )