[pull] main from adobe:main#431
Merged
Merged
Conversation
* fix: table resizing click stuck * fix cursor styles * fix formatting * fix lint * alternative approach following v3 * lint * fix format * remove extra comment
…ogue (#9807) * fix(react-aria-components): pass overlay id to PopoverContext in DialogTrigger (#9800) * fix format * fix(react-aria-components): apply overlay id to element with role=dialog in DialogTrigger Send overlay id to both DialogContext and PopoverContext, and have Popover only apply the id when it has role="dialog" — so the id lands on whichever element is the dialog, whether that's a nested Dialog or the Popover itself. * fix(react-aria-components): add id to PopoverInnerProps to fix typecheck * fix(test-utils): remove unnecessary nested dialog lookup in DialogTester --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )