[pull] main from adobe:main#443
Merged
Merged
Conversation
…10159) * initial changes to support textfields in gridlists * use robs event leak type select and prevent space from triggering selection when in input field * fix tests, but also use a more robust check instead of active element the failing tests didnt focus the element when triggering a keypress * add S2 Card story and tests for tree and gridlist * make presses on components in rows not trigger selection * add docs for rac * update docs and dedupe tree logic in useGridListItem keyboard handlers * create stories for table with textfields * support textfields in tables * add tests * add table docs and update copy * fix missing s2 table columnheader focus ring and add focus ring to the select all column cell * formatting * make editable table edit buttons focusable via tab when using tab keyboard behavior * clean up uneeded code and mirror useGridListItem more closely * add focusMode to Cell, make S2 TableView auto focus selection checkboxes, column menus, etc when in tab nav mode * add focusMode to gridListItem * add allowsArrowNavigation so arrow key navigation can be triggered even when in tab navigation and on a child of a cell/row * add allowsArrowNavigation and focusMode to tree, tests, and docs updates * add docs for focusMode/allowsArrowNavigation * move press selection prevention logic into useSelectableItem * fix case where click on cell didnt trigger row selection * fix case with nested collections and other review comments * clean up tests so it uses one table implementation * make sure shift tabbing from a child of a cell doesnt move focus back to cell if focusMode="child" and in tab nav * add coverage tests * fix lint * restore table column header default --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )