feat(deps): upgrade to Spring Boot 4 #4558
Draft
+1,332
−1,147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hmmm ... The de.codecentric.boot.admin.client.ClientServletApplicationTest hangs forever (in my fork build) ... Is this normal? 
Locally its "working" ... 
|
Author
|
I found a major problem ... may you guys have an idea ... Currently de.codecentric.boot.admin.client.config.SpringBootAdminClientRegistrationClientAutoConfigurationTest is failing for some of the defined "what kind of RegistrationClient is used" tests ... because de.codecentric.boot.admin.client.config.SpringBootAdminClientAutoConfiguration is mixing restclient and webclient and the bean-conditions which working with sb 3.5.x are no longer working because of the new splitting of the springboot dependencies ... may I'm wrong ... 
|
Author
|
jolokia-support-spring is also not ready yet for spring-boot 4: jolokia/jolokia#866 |
SteKoe
force-pushed
the
feat/migrate-to-springboot-4
branch
from
c6403c2 to
13573fd
Compare
SteKoe
changed the title
SteKoe
changed the title
Author
|
I update the fork to M3 ... now some more new "incompatibilities" present ... all about jackson. For example in de.codecentric.boot.admin.server.utils.jackson.EndpointMixinTest 
The new org.springframework.boot.test.json.JacksonTester.initFields(Object, JsonMapper) accept only tools.jackson.databind.json.JsonMapper from jackson-databind-3.0.0-rc9. I can't find anything in spring's migration guide for this changes :-( https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide |
TODO: Fix Autoconfiguration for RegistrationClient
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
06958f3 to
e9f78f0
Compare
Author
|
I rebased #4838 in my fork as well. |
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
4ccf0e6 to
4a96e55
Compare
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
4a96e55 to
95253b1
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…4903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7.5 (codecentric#4909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7.6 (codecentric#4911) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…around Reactor 3.8.0 blocking detection
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- the CountDownLatch.await should have a timeout too
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
- cleaned also all "invalid" code-formattings from previous commits - one big problem in spring-boot-admin-server jackson's databind module 3.0.0-rc9 was included into spring which conflicts here and there with the old jackson stuff?!
…ric/boot/admin/server/web/InstancesControllerIntegrationTest.java (post-rebase)
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
50d9945 to
85da481
Compare
- Remove projectreactor-blockhound.version property from main pom.xml - Remove blockhound dependency from dependency management - Aligns with upstream spring-boot-4 branch which has no blockhound config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.