Skip to content

Complete benchmark task 1 with S model - #5559

Open
NICEHey wants to merge 1 commit into
codecentric:masterfrom
NICEHey:benchmark-s-task1
Open

Complete benchmark task 1 with S model#5559
NICEHey wants to merge 1 commit into
codecentric:masterfrom
NICEHey:benchmark-s-task1

Conversation

@NICEHey

@NICEHey NICEHey commented Jul 24, 2026

Copy link
Copy Markdown

No description provided.

@NICEHey
NICEHey requested a review from a team as a code owner July 24, 2026 06:39
@SteKoe

SteKoe commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Hey @NICEHey,

what's this all about? What is the purpose? Which problem did you solve? What is S model and what is task 1?

@cdprete

cdprete commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

@SteKoe

What is S model and what is task 1?

AI :D

what's this all about? What is the purpose? Which problem did you solve?

According to the comment

// The backend SSE stream re-publishes the new application (with the migrated
// instance) and then the previous application with an empty instance list so
// the store can drop it. The instance's registration.name changes while the
// id/healthUrl stay the same.

I think he's trying to fix the renaming of an application.
What puzzles me is, how is he doing it?. Is he doing it at runtime somehow?
That's the only scenario - in the context of the change - where I think indeed there may be some issues in the current codebase.

Moreover, the model objects should not be changed.
If this is allowed, I would then argue that the suggestion provided in #5416 to just change the status update event to carry also the health groups should have also be applied instead of having yet another cache and another scheduler that take up resources.
But, that suggestion was rejected by @ulischulte exactly because the model should not be touched since it's exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants