fix: build x86_64 linux binary on glibc 2.31#738
Merged
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
thomasrockhu-codecov
force-pushed
the
th/fix-linux-glibc-x86_64
branch
from
951ce0c to
515f936
Compare
PR #725 dropped the Dockerized ubuntu:20.04 x86_64 build and started building codecovcli_linux on the ubuntu-22.04 runner (glibc 2.35), breaking the binary on older distros such as AL2023 (glibc 2.34). Restore the ubuntu:20.04 x86_64 build in the Dockerized job following the pre-#725 pattern (wildcard codecovcli_* path, glibc compatibility notes), and use file_glob so build_linux.sh's renamed output is published as the canonical codecovcli_linux asset.
thomasrockhu-codecov
force-pushed
the
th/fix-linux-glibc-x86_64
branch
from
515f936 to
e2009e1
Compare
calvin-codecov
approved these changes
Jul 9, 2026
Comment on lines
115
to
+116
| name: codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }} | ||
| path: ./dist/codecovcli_${{ matrix.distro_name }}_${{ matrix.arch }} | ||
| path: ./dist/codecovcli_* |
Contributor
There was a problem hiding this comment.
These could be mismatched now making it harder to discern if we were to debug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build codecovcli_linux in the ubuntu:20.04 Docker container (glibc 2.31) instead of on the ubuntu-22.04 runner (glibc 2.35). PR #725 dropped the Dockerized x86_64 build, causing the binary to require glibc 2.35 and break on older distros such as AL2023 (glibc 2.34).